Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use pull_request instead of pull_request_target (#6743) #6925

Merged
merged 1 commit into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/backport.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Backport
on:
pull_request_target:
pull_request:
types:
- closed
- labeled
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check_pr_labels.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: PRs labels check

on:
pull_request_target:
pull_request:
types: [opened, reopened, ready_for_review, labeled, unlabeled, synchronize]

jobs:
Expand Down
21 changes: 11 additions & 10 deletions .github/workflows/e2e_trigger_via_label.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@ jobs:
PR_NUMBER: ${{ github.event.pull_request.number }}

steps:
- uses: actions/checkout@v4
# Do not run e2e tests on GKE-based clusters for specific PR, because currently
# there is no way to use an image built from PR's code for those tests.
# https://github.com/Kong/kubernetes-testing-framework/issues/587
- run: |
gh workflow run ${WORKFLOW} --ref ${BRANCH} \
-f run-gke=false \
-f run-istio=true \
-f all-supported-k8s-versions=true \
-f pr-number=${PR_NUMBER}
- name: checkout repository
uses: actions/checkout@v4
# Do not run e2e tests on GKE-based clusters for specific PR, because currently
# there is no way to use an image built from PR's code for those tests.
# https://github.com/Kong/kubernetes-testing-framework/issues/587
- run: |
gh workflow run ${WORKFLOW} --ref ${BRANCH} \
-f run-gke=false \
-f run-istio=true \
-f all-supported-k8s-versions=true \
-f pr-number=${PR_NUMBER}
Loading