Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): dedicated rels package #6889

Merged
merged 1 commit into from
Dec 23, 2024
Merged

chore(refactor): dedicated rels package #6889

merged 1 commit into from
Dec 23, 2024

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

Address comment/fulfill promise

of putting relations-related code into a separate package. Name rels has been chosen to not be too long and not to steal great variable names like relation, relations and rel.

@programmer04 programmer04 self-assigned this Dec 20, 2024
@programmer04 programmer04 requested a review from a team as a code owner December 20, 2024 16:24
@programmer04 programmer04 enabled auto-merge (squash) December 20, 2024 17:21
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.4%. Comparing base (b14df00) to head (5504b84).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/dataplane/kongstate/kongstate.go 82.3% 3 Missing ⚠️
internal/dataplane/kongstate/customentity.go 77.7% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #6889      +/-   ##
========================================
+ Coverage   59.0%   76.4%   +17.3%     
========================================
  Files        210     212       +2     
  Lines      25241   25246       +5     
========================================
+ Hits       14917   19297    +4380     
+ Misses      9030    4928    -4102     
+ Partials    1294    1021     -273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 merged commit e5dd02f into main Dec 23, 2024
73 checks passed
@programmer04 programmer04 deleted the refactor-rel branch December 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants