-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve panic in resourceErrorFromEntityAction #6800
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6800 +/- ##
=======================================
+ Coverage 77.6% 77.7% +0.1%
=======================================
Files 207 207
Lines 24644 24679 +35
=======================================
+ Hits 19131 19183 +52
+ Misses 4528 4516 -12
+ Partials 985 980 -5 ☔ View full report in Codecov by Sentry. |
687aaab
to
66c7afa
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12236452121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
What this PR does / why we need it:
TestDeployAllInOneEnterprisePostgres
Minimal, interactive example that reproduces the issue - https://go.dev/play/p/BI7vSuUQ996
Go sometimes makes questionable decisions regarding its API, and this is an example of one. Community reported exactly the same case as we encountered, see
and read details. Any suggestion for improvement was unfortunately rejected, thus we have to live with it. Such rough edges make Go a not-so-safe language, IMHO. But on the other hand, creator discoureages usage of reflections with the proverb - Reflection is never clear
Which issue this PR fixes:
Closes #6797