Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve panic in resourceErrorFromEntityAction #6800

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Dec 9, 2024

What this PR does / why we need it:

TestDeployAllInOneEnterprisePostgres

Minimal, interactive example that reproduces the issue - https://go.dev/play/p/BI7vSuUQ996

Go sometimes makes questionable decisions regarding its API, and this is an example of one. Community reported exactly the same case as we encountered, see

and read details. Any suggestion for improvement was unfortunately rejected, thus we have to live with it. Such rough edges make Go a not-so-safe language, IMHO. But on the other hand, creator discoureages usage of reflections with the proverb - Reflection is never clear

Which issue this PR fixes:

Closes #6797

@programmer04 programmer04 added area/tests area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. fix labels Dec 9, 2024
@programmer04 programmer04 added this to the KIC v3.4.x milestone Dec 9, 2024
@programmer04 programmer04 self-assigned this Dec 9, 2024
@programmer04 programmer04 added ci/run-e2e Trigger e2e test run from PR and removed size/XS labels Dec 9, 2024
@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.7%. Comparing base (76062fc) to head (66c7afa).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
internal/dataplane/sendconfig/dbmode.go 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6800     +/-   ##
=======================================
+ Coverage   77.6%   77.7%   +0.1%     
=======================================
  Files        207     207             
  Lines      24644   24679     +35     
=======================================
+ Hits       19131   19183     +52     
+ Misses      4528    4516     -12     
+ Partials     985     980      -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kong Kong deleted a comment from team-k8s-bot Dec 9, 2024
@Kong Kong deleted a comment from team-k8s-bot Dec 9, 2024
@programmer04 programmer04 added the ci/run-e2e Trigger e2e test run from PR label Dec 9, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12236452121

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Dec 9, 2024
@programmer04 programmer04 marked this pull request as ready for review December 9, 2024 13:27
@programmer04 programmer04 requested a review from a team as a code owner December 9, 2024 13:27
@programmer04 programmer04 enabled auto-merge (squash) December 9, 2024 13:29
@programmer04 programmer04 changed the title fix: resolve panic in TestDeployAllInOneEnterprisePostgres fix: resolve panic in resourceErrorFromEntityAction Dec 9, 2024
@programmer04 programmer04 disabled auto-merge December 9, 2024 13:59
@programmer04 programmer04 enabled auto-merge (squash) December 9, 2024 13:59
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@programmer04 programmer04 merged commit 1523c85 into main Dec 9, 2024
146 checks passed
@programmer04 programmer04 deleted the fix-test-panic branch December 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. fix size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in resourceErrorFromEntityAction
3 participants