feat: dump custom entities in config fetcher #6305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
feat/config_fetcher_custom_entities
branch
2 times, most recently
from
870d710 to
34893b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6305 +/- ##
======================================
Coverage ? 75.9%
======================================
Files ? 200
Lines ? 20173
Branches ? 0
======================================
Hits ? 15314
Misses ? 3844
Partials ? 1015 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/config_fetcher_custom_entities
branch
from
34893b4 to
b5e6ab2
Compare
|
Dependent on Kong/go-database-reconciler#114. Waiting for GDR release with the contents in the PR to support dumping custom entities. |
randmonkey
force-pushed
the
feat/config_fetcher_custom_entities
branch
from
b5e6ab2 to
b335d42
Compare
randmonkey
changed the title
randmonkey
force-pushed
the
feat/config_fetcher_custom_entities
branch
from
b335d42 to
1c2d5fe
Compare
pmalek
previously approved these changes
Jul 23, 2024
pmalek
reviewed
Jul 24, 2024
randmonkey
force-pushed
the
feat/config_fetcher_custom_entities
branch
from
a903ca1 to
39c0c90
Compare
Co-authored-by: Jakub Warczarek <[email protected]>
randmonkey
force-pushed
the
feat/config_fetcher_custom_entities
branch
from
39c0c90 to
c8c1bac
Compare
pmalek
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add custom entities in config fetcher to support them in config recovery.
Which issue this PR fixes:
Should fix #6054
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR