Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.12.x] chore: upgrade KTF and pin Kuma to 2.6.2 #5760

Merged
merged 3 commits into from
Apr 4, 2024
Merged

[2.12.x] chore: upgrade KTF and pin Kuma to 2.6.2 #5760

merged 3 commits into from
Apr 4, 2024

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Mar 27, 2024 •
edited
Loading

Updates KTF to 0.39.2. Draft pending actual release of that.

Pins the 2.12.x Kuma test version to 2.6.2 (essentially arbitrary, it's just the current version used in main). main currently manages this via Renovate, but the 2.12.x branch does not have Renovate set up. Doing so is possible (https://docs.renovatebot.com/configuration-options/#basebranches allows updating more than one branch) at the cost of some additional setup and maintenance, though we generally don't provide any guarantees of forward compatibility for LTS KIC, so IDK if we'd want to bother.

Backports #5507 for the same reason we originally did that.

@rainest rainest added the ci/run-e2e Trigger e2e test run from PR label Mar 27, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8458441457

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Mar 27, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.0%. Comparing base (b929f67) to head (2768031).
Report is 5 commits behind head on release/2.12.x.

Additional details and impacted files 
@@              Coverage Diff               @@
##           release/2.12.x   #5760   +/-   ##
==============================================
  Coverage            68.0%   68.0%           
==============================================
  Files                 165     165           
  Lines               19344   19352    +8     
==============================================
+ Hits                13159   13168    +9     
  Misses               5397    5397           
+ Partials              788     787    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey
Copy link
Contributor

We still need to pin the kuma version because without version, kuma addon in KTF could not recognize the version and cannot configure the allowAllTrafficPermission settings. See: Kong/kubernetes-testing-framework#1017 (comment)

@rainest
wip(e2e) use more modern Kuma setup
a913d9c 
Set the Kuma version and use a more modern addon builder.

Currently uses an unreleased KTF version.
@rainest rainest force-pushed the chore/ktf-backport branch from 676ea73 to a913d9c Compare March 28, 2024 17:45
@rainest rainest added size/XS ci/run-e2e Trigger e2e test run from PR and removed size/S labels Mar 28, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8471491584

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Mar 28, 2024
@randmonkey @czeslavo @rainest
test(e2e): set appProtocol to HTTP for kuma tests (#5507)
dec4392 
* set appProtocol to HTTP for kuma tests

* Update test/e2e/helpers_test.go

Co-authored-by: Grzegorz Burzyński <[email protected]>

---------

Co-authored-by: Grzegorz Burzyński <[email protected]>
@rainest rainest added the ci/run-e2e Trigger e2e test run from PR label Mar 28, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8473225109

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Mar 28, 2024
@rainest rainest mentioned this pull request Mar 28, 2024
Merged
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Mar 29, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8479837105

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Mar 29, 2024
@rainest rainest marked this pull request as ready for review April 1, 2024 20:17
@rainest rainest requested a review from a team as a code owner April 1, 2024 20:17
@rainest rainest enabled auto-merge (squash) April 1, 2024 20:18
@pmalek pmalek changed the title wip: upgrade KTF [2.12.x] chore: upgrade KTF and pin Kuma to 2.6.2 Apr 4, 2024
@rainest rainest merged commit d5f7a16 into release/2.12.x Apr 4, 2024
192 checks passed
@rainest rainest deleted the chore/ktf-backport branch April 4, 2024 14:17
@pmalek pmalek mentioned this pull request Apr 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rainest @team-k8s-bot @randmonkey @pmalek @czeslavo