fix(manager) restore InitCacheSyncDuration (#5238) #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression that removed initial cache sync delay. Add --init-cache-sync-duration flag to override the delay period. --------- Co-authored-by: Travis Raines <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.x #5261 +/- ##
================================================
Coverage ? 68.0%
================================================
Files ? 165
Lines ? 19344
Branches ? 0
================================================
Hits ? 13171
Misses ? 5389
Partials ? 784 ☔ View full report in Codecov by Sentry. |
czeslavo
reviewed
Nov 30, 2023
czeslavo
approved these changes
Dec 1, 2023
mlavacca
approved these changes
Dec 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport of #5238 to 2.12.
Special notes for your reviewer:
Obliterated changelog conflicts. AFAIK we're just leaving these as-is in the release branch and adding new patch info to main only at release time.
Ran
make generatefor the CLI doc.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:theCHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR