-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use only 46 bits for priorities of Kong routes #5024
Conversation
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6701692323 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5024 +/- ##
=======================================
- Coverage 75.3% 75.3% -0.1%
=======================================
Files 167 167
Lines 18721 18721
=======================================
- Hits 14104 14100 -4
- Misses 3790 3792 +2
- Partials 827 829 +2
☔ View full report in Codecov by Sentry. |
a7406e1
to
dd2d339
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6702831067 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.12.x release/2.12.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.12.x
# Create a new branch
git switch --create backport-5024-to-release/2.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2475f344850bf9b6722d0cac508a8a2866b8fee
# Push it to GitHub
git push --set-upstream origin backport-5024-to-release/2.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.12.x Then, create a pull request where the |
* fix: use only 46 bits for priorities of Kong routes (cherry picked from commit b2475f3)
* fix: use only 46 bits for priorities of Kong routes (cherry picked from commit b2475f3) Co-authored-by: Tao Yi <[email protected]>
What this PR does / why we need it:
Use only 46 bits in calculated
priority
of generated Kong routes when expression router is enabled. This prevent Kong gateway to decode it to scientific notation that will cause precision loss in dumping and comparing the configurations.Which issue this PR fixes:
fixes #5009 and also #4990.
Special notes for your reviewer:
Review on changelog: should this change be notated as a
Breaking change
?PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR