fix: set router flavor to traditional_compatible in konnect related manifests

[randmonkey]

What this PR does / why we need it:

Konnect seems not to support expression routes. We need to set router flavor to traditional_compatible to pass e2e tests for integration with Konnect.

Which issue this PR fixes:

fixes #4993
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

• the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

[team-k8s-bot]

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6664188466

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1351004) 77.6% compared to head (a23412b) 75.2%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #4994     +/-   ##
=======================================
- Coverage   77.6%   75.2%   -2.4%     
=======================================
  Files        167     167             
  Lines      18709   18709             
=======================================
- Hits       14527   14087    -440     
- Misses      3345    3794    +449     
+ Partials     837     828      -9     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[czeslavo]

Shouldn't we instead of fixing it this way, make sure Koko works before the KIC 3.0 release given we want to use expressions router as default?

[randmonkey]

Shouldn't we instead of fixing it this way, make sure Koko works before the KIC 3.0 release given we want to use expressions router as default?

This means KIC 3.0 is blocked on the koko bug fixed and deployed to Konnect.

[czeslavo]

This means KIC 3.0 is blocked on the koko bug fixed and deployed to Konnect.

That sounds to me like a decision to be made by @mheap whether we want to rely on Koko fix to be delivered before the release, or do we want to document that expressions do not work with KIC-Konnect integration for now.

[mheap]

We will set traditional_compatible for Konnect in the values.yaml provided by the UI. We should merge this PR until the Koko fix is delivered

[pmalek]

We will set traditional_compatible for Konnect in the values.yaml provided by the UI. We should merge this PR until the Koko fix is delivered

👍 Please note that @mheap is referring to UI instructions which use the helm chart, so this change here does fix our manifests but do not really influence the chart in any way.

Let's merge this to make sure we have passing e2e suite and let's create a follow up issue to change the default router flavor in konnect manifest to expressions when that's solved on koko's side.

[pmalek]

I've created #4995 to track re-introduction of expressions router flavor into Konnect manifests.