test(integration): remove skipTestForExpressionRouter helper in tests #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
changed the title
randmonkey
force-pushed
the
test/remove_skipTestForExpressionRouter
branch
from
2fae76a to
244f35d
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4881 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 164 164
Lines 18399 18443 +44
=====================================
+ Hits 14298 14342 +44
- Misses 3281 3282 +1
+ Partials 820 819 -1 ☔ View full report in Codecov by Sentry. |
czeslavo
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
use
skipTestForRouterFlavorsinstead ofskipTestForExpressionRouterto skip tests not expected to run with expression router, and remove the skip for unnecessary cases.Which issue this PR fixes:
part of #4719
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR