Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LB IP missing no longer an error #4066

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on May 24, 2023

  1. feat: LB IP missing no longer an error

    After this commit a LoadBalancer service that has no external IP
    addresses listed in the status is no longer a reconciliation error.
    
    We're changing the semtantics from "KIC failed to reconcile" to
    "KIC reconciled this publish service okay, it just happens to have
    zero public IP addresses".
    
    Why are we making this change? To allow for a more user-friendly
    message than this:
    
        [kong-controller-75896f8d9b-4hwbq] time="2023-05-24T11:26:03Z" level=error msg="Reconciler error" error="waiting for addresses to be provisioned for publish service kong/kong-proxy-proxy" logger=controllers.Ingress.netv1 reconcileID="\"f97e4634-0d72-4882-bdd9-9a5b2e5339b6\""
    mflendrich committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0712b6e View commit details
    Browse the repository at this point in the history