Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom entities in last known good configuration #6054

Closed
2 of 4 tasks
randmonkey opened this issue May 20, 2024 · 1 comment · Fixed by #6305
Closed
2 of 4 tasks

Support custom entities in last known good configuration #6054

randmonkey opened this issue May 20, 2024 · 1 comment · Fixed by #6305
Assignees
Labels
area/CRD Changes in existing CRDs or introduction of new ones release/required it is required that this be resolved before releasing
Milestone

Comments

@randmonkey
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

Split from #4556 .
We do not have the method to fetch custom entities from Kong raw state. To support back filling custom entities from last good known config from Kong gateway, we need to parse and fill custom entities (entities not directly supported) in config fetcher. This needs go-database-reconciler to support custom entities.

Proposed Solution

  • Support dumping custom entities from Kong gateway in go-database-reconciler
  • Dump custom entities from Kong raw state fetched from Kong gateway in last good config
  • Load last good config with custom entities when applying config failed

Additional information

No response

Acceptance Criteria

  • KIC can dump custom entities to KongState structure from Kong raw state fetched from Kong gateway
  • KIC can apply config with custom entities stored in last known good config when applying Kong config fails.
@randmonkey randmonkey added area/CRD Changes in existing CRDs or introduction of new ones blocked labels May 20, 2024
@randmonkey
Copy link
Contributor Author

randmonkey commented May 20, 2024

Mark it as blocked since this needs go-database-reconciler to support dumping custom entities.
Blocked by: Kong/go-database-reconciler#110.

@randmonkey randmonkey added this to the KIC 3.3.x milestone May 20, 2024
@lahabana lahabana added the release/required it is required that this be resolved before releasing label Jun 24, 2024
@randmonkey randmonkey self-assigned this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones release/required it is required that this be resolved before releasing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants