-
Notifications
You must be signed in to change notification settings - Fork 594
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: allow configuring cluster domain and use FQDN for upstream serv…
…ice targets (#6697) * feat: allow configuring cluster domain and use FQDN for upstream service targets * Update CHANGELOG.md * chore: extract manager's consts to a separate consts package * chore: generate CLI args --------- Co-authored-by: Mattia Lavacca <[email protected]>
- Loading branch information
Showing
10 changed files
with
121 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package consts | ||
|
||
// ----------------------------------------------------------------------------- | ||
// Controller Manager - Constants & Vars | ||
// ----------------------------------------------------------------------------- | ||
|
||
const ( | ||
// HealthzPort is the default port the manager's health service listens on. | ||
// Changing this will result in a breaking change. Existing deployments may use the literal | ||
// port number in their liveness and readiness probes, and upgrading to a controller version | ||
// with a changed HealthzPort will result in crash loops until users update their probe config. | ||
// Note that there are several stock manifests in this repo that also use the literal port number. If you | ||
// update this value, search for the old port number and update the stock manifests also. | ||
HealthzPort = 10254 | ||
|
||
// MetricsPort is the default port the manager's metrics service listens on. | ||
// Similar to HealthzPort, it may be used in existing user deployment configurations, and its | ||
// literal value is used in several stock manifests, which must be updated along with this value. | ||
MetricsPort = 10255 | ||
|
||
// DiagnosticsPort is the default port of the manager's diagnostics service listens on. | ||
DiagnosticsPort = 10256 | ||
|
||
// KongClientEventRecorderComponentName is a KongClient component name used to identify the events recording component. | ||
KongClientEventRecorderComponentName = "kong-client" | ||
|
||
// DefaultClusterDomain is the default cluster domain used by the controller. | ||
// TODO: change this in next major release: https://github.com/Kong/kubernetes-ingress-controller/issues/6756 | ||
DefaultClusterDomain = "" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbfdbeb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.BenchmarkGetPluginRelations
17285
ns/op 7296 B/op 66 allocs/op7422
ns/op 7296 B/op 66 allocs/op2.33
BenchmarkGetPluginRelations - ns/op
17285
ns/op7422
ns/op2.33
This comment was automatically generated by workflow using github-action-benchmark.
CC: @Kong/k8s-maintainers