Skip to content

Commit

Permalink
rollback appProtocol change
Browse files Browse the repository at this point in the history
  • Loading branch information
czeslavo committed Feb 2, 2024
1 parent f14aeb0 commit 4c4c8b1
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions test/e2e/helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -411,12 +411,6 @@ func deployIngressWithEchoBackends(ctx context.Context, t *testing.T, env enviro

t.Logf("exposing deployment %s via service", deployment.Name)
service := generators.NewServiceForDeployment(deployment, corev1.ServiceTypeClusterIP)
for i := range service.Spec.Ports {
// Set Service's appProtocol to http so that Kuma load-balances requests on HTTP-level instead of TCP.
// TCP load-balancing proved to cause issues with not distributing load evenly in short time spans like in this test.
// Ref: https://github.com/Kong/kubernetes-ingress-controller/issues/5498
service.Spec.Ports[i].AppProtocol = lo.ToPtr("http")
}
_, err = env.Cluster().Client().CoreV1().Services(corev1.NamespaceDefault).Create(ctx, service, metav1.CreateOptions{})
require.NoError(t, err)
t.Cleanup(func() {
Expand Down

0 comments on commit 4c4c8b1

Please sign in to comment.