feat: make konnect entities spec.konnect.authRef immutable only when entity is already programmed #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
make-konnect-authRef-immutable-only-when-programmed
branch
from
4fbea76 to
9fccfac
Compare
pmalek
force-pushed
the
make-konnect-authRef-immutable-only-when-programmed
branch
2 times, most recently
from
e34d5b0 to
0eb947e
Compare
pmalek
force-pushed
the
make-konnect-authRef-immutable-only-when-programmed
branch
from
0eb947e to
c180eb4
Compare
…entity is already programmed
pmalek
force-pushed
the
make-konnect-authRef-immutable-only-when-programmed
branch
from
c180eb4 to
ab619db
Compare
czeslavo
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes it possible to fix a broken authRef instead of requiring users to delete the object and recreate it with a fixed authRef.
This change makes the authRef mutable when
Programmedcondition with status set toTrueAPIAuthValidcondition with status set toTrueWhich issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes