feat: disallow cross namespace services refs (#107)

Kong · Oct 3, 2024 · d3282d5 · d3282d5
1 parent dd5a5f6
commit d3282d5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/api/configuration/v1alpha1/service_ref.go b/api/configuration/v1alpha1/service_ref.go
@@ -16,10 +16,13 @@ type ServiceRef struct {
 	NamespacedRef *NamespacedServiceRef `json:"namespacedRef,omitempty"`
 }
 
+// NamespacedServiceRef is a namespaced reference to a KongService.
+//
+// NOTE: currently cross namespace references are not supported.
 type NamespacedServiceRef struct {
 	// +kubebuilder:validation:Required
 	Name string `json:"name"`
 
-	// +kubebuilder:validation:Optional
-	Namespace string `json:"namespace,omitempty"`
+	// TODO: handle cross namespace references.
+	// https://github.com/Kong/kubernetes-configuration/issues/106
 }
diff --git a/config/crd/bases/configuration.konghq.com_kongroutes.yaml b/config/crd/bases/configuration.konghq.com_kongroutes.yaml
@@ -194,8 +194,6 @@ spec:
                     properties:
                       name:
                         type: string
-                      namespace:
-                        type: string
                     required:
                     - name
                     type: object

diff --git a/docs/api-reference.md b/docs/api-reference.md
@@ -1543,14 +1543,14 @@ _Appears in:_
 #### NamespacedServiceRef
 
 
-
+NamespacedServiceRef is a namespaced reference to a KongService.<br /><br />
+NOTE: currently cross namespace references are not supported.
 
 
 
 | Field | Description |
 | --- | --- |
 | `name` _string_ |  |
-| `namespace` _string_ |  |
 
 
 _Appears in:_