Skip to content

Commit

Permalink
commented out GenericEntityRef
Browse files Browse the repository at this point in the history
Signed-off-by: Mattia Lavacca <[email protected]>
  • Loading branch information
mlavacca committed Jul 25, 2024
1 parent 53b6398 commit bd0d1e7
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions api/configuration/v1alpha1/kongpluginbinding_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,20 +117,20 @@ type EntityRef struct {
Name string `json:"name"`
}

type GenericEntityRef struct {
// Name is the name of the generic entity.
// +kubebuilder:validation:Required
Name string `json:"name"`

// kind is the kind of the entity.
// +kubebuilder:validation:Enum=Service;HTTPRoute;GCPRoute;TLSRoute;TCPRoute;UDPRoute;Ingress
Kind string `json:"kind"`

// TODO(mlavacca): add cross-field validation. Kind can be set depending on the group.
// Group is the group of the entity.
// +kubebuilder:validation:Enum="";core;gateway.networking.k8s.io;networking.k8s.io
Group string `json:"group"`
}
// type GenericEntityRef struct {
// // Name is the name of the generic entity.
// // +kubebuilder:validation:Required
// Name string `json:"name"`

// // kind is the kind of the entity.
// // +kubebuilder:validation:Enum=Service;HTTPRoute;GCPRoute;TLSRoute;TCPRoute;UDPRoute;Ingress
// Kind string `json:"kind"`

// // TODO(mlavacca): add cross-field validation. Kind can be set depending on the group.
// // Group is the group of the entity.
// // +kubebuilder:validation:Enum="";core;gateway.networking.k8s.io;networking.k8s.io
// Group string `json:"group"`
// }

// KongPluginBindingStatus represents the current status of the KongBinding resource.
type KongPluginBindingStatus struct {
Expand Down

0 comments on commit bd0d1e7

Please sign in to comment.