feat: added cel to pluginbinding kong field

Signed-off-by: Mattia Lavacca <[email protected]>
Kong · Jul 25, 2024 · aa710cf · aa710cf
1 parent da37fe0
commit aa710cf
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/api/configuration/v1alpha1/kongpluginbinding_types.go b/api/configuration/v1alpha1/kongpluginbinding_types.go
@@ -31,6 +31,7 @@ import (
 // +kubebuilder:printcolumn:name="Plugin-kind",type=string,JSONPath=`.spec.pluginReference.kind`,description="Kind of the plugin"
 // +kubebuilder:printcolumn:name="Plugin-name",type=string,JSONPath=`.spec.pluginReference.name`,description="Name of the plugin"
 // +kubebuilder:printcolumn:name="Programmed",description="The Resource is Programmed",type=string,JSONPath=`.status.conditions[?(@.type=='Programmed')].status`
+// +kubebuilder:validation:XValidation:rule="(has(self.spec.kong.consumerRef) && has(self.spec.kong.routeRef) && has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.consumerGroupRef) && has(self.spec.kong.serviceRef) && has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerRef)) || (has(self.spec.kong.consumerRef) && has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerGroupRef) && !has(self.spec.kong.serviceRef)) || (has(self.spec.kong.consumerRef) && has(self.spec.kong.serviceRef) && !has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.consumerGroupRef) && has(self.spec.kong.routeRef) && !has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerRef)) || (has(self.spec.kong.consumerGroupRef) && has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerRef) && !has(self.spec.kong.routeRef)) || (has(self.spec.kong.routeRef) && has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerRef) && !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.consumerRef) && !has(self.spec.kong.serviceRef) && !has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.consumerGroupRef) && !has(self.spec.kong.serviceRef) && !has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerRef)) || (has(self.spec.kong.routeRef) && !has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerRef) && !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.serviceRef) && !has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerGroupRef) && !has(self.spec.kong.consumerRef))", message="The combinations of entities set is not allowed"
 type KongPluginBinding struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
@@ -90,8 +91,6 @@ type KongPluginBindingSpec struct {
 
 type KongReferences struct {
 	// TODO(mlavacca): add validation that at least one of the following field is properly set.
-	// TODO(mlavacca): add validation to ensure that when genericEntityReference is set, no other reference is set.
-
 	RouteReference         *EntityRef `json:"routeRef,omitempty"`
 	ServiceReference       *EntityRef `json:"serviceRef,omitempty"`
 	ConsumerReference      *EntityRef `json:"consumerRef,omitempty"`

diff --git a/config/crd/bases/configuration.konghq.com_kongpluginbindings.yaml b/config/crd/bases/configuration.konghq.com_kongpluginbindings.yaml
@@ -92,6 +92,8 @@ spec:
                     - name
                     type: object
                   routeRef:
+                    description: 'TODO(mlavacca): add validation that at least one
+                      of the following field is properly set.'
                     properties:
                       name:
                         description: Name is the name of the entity.
@@ -244,6 +246,30 @@ spec:
         required:
         - spec
         type: object
+        x-kubernetes-validations:
+        - message: The combinations of entities set is not allowed
+          rule: (has(self.spec.kong.consumerRef) && has(self.spec.kong.routeRef) &&
+            has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerGroupRef))
+            || (has(self.spec.kong.consumerGroupRef) && has(self.spec.kong.serviceRef)
+            && has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerRef)) ||
+            (has(self.spec.kong.consumerRef) && has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerGroupRef)
+            && !has(self.spec.kong.serviceRef)) || (has(self.spec.kong.consumerRef)
+            && has(self.spec.kong.serviceRef) && !has(self.spec.kong.routeRef) &&
+            !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.consumerGroupRef)
+            && has(self.spec.kong.routeRef) && !has(self.spec.kong.serviceRef) &&
+            !has(self.spec.kong.consumerRef)) || (has(self.spec.kong.consumerGroupRef)
+            && has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerRef)
+            && !has(self.spec.kong.routeRef)) || (has(self.spec.kong.routeRef) &&
+            has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerRef) &&
+            !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.consumerRef)
+            && !has(self.spec.kong.serviceRef) && !has(self.spec.kong.routeRef) &&
+            !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.consumerGroupRef)
+            && !has(self.spec.kong.serviceRef) && !has(self.spec.kong.routeRef) &&
+            !has(self.spec.kong.consumerRef)) || (has(self.spec.kong.routeRef) &&
+            !has(self.spec.kong.serviceRef) && !has(self.spec.kong.consumerRef) &&
+            !has(self.spec.kong.consumerGroupRef)) || (has(self.spec.kong.serviceRef)
+            && !has(self.spec.kong.routeRef) && !has(self.spec.kong.consumerGroupRef)
+            && !has(self.spec.kong.consumerRef))
     served: true
     storage: true
     subresources:

diff --git a/docs/api-reference.md b/docs/api-reference.md
@@ -648,7 +648,7 @@ _Appears in:_
 
 | Field | Description |
 | --- | --- |
-| `routeRef` _[EntityRef](#entityref)_ |  |
+| `routeRef` _[EntityRef](#entityref)_ | TODO(mlavacca): add validation that at least one of the following field is properly set. |
 | `serviceRef` _[EntityRef](#entityref)_ |  |
 | `consumerRef` _[EntityRef](#entityref)_ |  |
 | `consumerGroupRef` _[EntityRef](#entityref)_ |  |