Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kalert): use proper danger icon #2550

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix(kalert): use proper danger icon #2550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/KAlert/KAlert.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ import { computed } from 'vue'
import type { PropType } from 'vue'
import type { AlertAppearance } from '@/types'
import { AlertAppearances } from '@/types'
import { InfoIcon, CheckCircleIcon, WarningIcon, ClearIcon, CloseIcon } from '@kong/icons'
import { InfoIcon, CheckCircleIcon, WarningIcon, DangerIcon, CloseIcon } from '@kong/icons'
import { KUI_ICON_SIZE_40 } from '@kong/design-tokens'

type AlertIcon = typeof InfoIcon // all icons are the same type so we can use any of them
Expand Down Expand Up @@ -92,7 +92,7 @@ const getAlertIcon = computed((): AlertIcon => {
case AlertAppearances.warning:
return WarningIcon
case AlertAppearances.danger:
return ClearIcon
return DangerIcon
default:
return InfoIcon // info as default in case of invalid appearance
}
Expand Down
Loading