Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slots): unwrap slots in mdc #2534

Closed
wants to merge 10 commits into from
Closed

Conversation

adamdehaven
Copy link
Member

@adamdehaven adamdehaven commented Dec 4, 2024

Summary

The @nuxt/mdc module recently added support for a mdc-unwrap slot prop that will allow unwrapping slotted data (e.g. removing a wrapping p tag).

In host projects where MDC is not utilized, the added slot props here have no effect; however, in the new portal project, the change will remove slotted p tags from inside common components.

Example

Before Change (in a Nuxt app)

<button class="k-button medium primary" type="button">
  <p>I'm a button</p>
</button>

After Change (in a Nuxt app)

<button class="k-button medium primary" type="button">
  I'm a button
</button>

Kongponents rendered HTML in a normal Vue app (e.g. inspect the docs link) is unchanged.

@adamdehaven adamdehaven self-assigned this Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 497de3c
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/676221534cef09000801a17e
😎 Deploy Preview https://deploy-preview-2534--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 497de3c
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67622153b537c1000855abac
😎 Deploy Preview https://deploy-preview-2534--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamdehaven adamdehaven deleted the feat/unwrap-slots-in-mdc branch December 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant