Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ktableview): align nested table with parent [KHCP-14265] #2533

Merged

Conversation

portikM
Copy link
Member

@portikM portikM commented Dec 2, 2024

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-14265

In the nested table, add spacing on the left to align it with the first column of the parent table

@portikM portikM self-assigned this Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit b883569
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/674f7ac4e50adc0008d5a5a6
😎 Deploy Preview https://deploy-preview-2533--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit b883569
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/674f7ac4ea48450008f86300
😎 Deploy Preview https://deploy-preview-2533--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM changed the title fix(ktableview): align nested table with parent [KHCP-14265] fix(ktableview): nested table ux improvements [KHCP-14265] Dec 3, 2024
@portikM portikM force-pushed the fix/khcp-14265-ktableview-nested-table-ux-improvements branch from 0116eeb to b883569 Compare December 3, 2024 21:40
@portikM portikM changed the title fix(ktableview): nested table ux improvements [KHCP-14265] fix(ktableview): align nested table with parent [KHCP-14265] Dec 3, 2024
@portikM portikM marked this pull request as ready for review December 3, 2024 21:40
@portikM portikM requested a review from a team as a code owner December 3, 2024 21:40
@portikM portikM merged commit 21ed3ec into main Dec 3, 2024
14 checks passed
@portikM portikM deleted the fix/khcp-14265-ktableview-nested-table-ux-improvements branch December 3, 2024 21:52
kongponents-bot pushed a commit that referenced this pull request Dec 3, 2024
## [9.14.19](v9.14.18...v9.14.19) (2024-12-03)

### Bug Fixes

* **ktableview:** align nested table with parent [KHCP-14265] ([#2533](#2533)) ([21ed3ec](21ed3ec))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.14.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants