Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ktableview, ktabledata): cell-attrs and row-attrs prop type #2490

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix(ktableview, ktabledata): cell-attrs and row-attrs prop type #2490

merged 2 commits into from
Oct 29, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Oct 29, 2024 •
edited
Loading

Summary

Accept Record<string, any> instead of Record<string, string> in cellAttrs & rowAttrs props in KTableView & KTableData.

Explanation:

// this isn't valid because style is object, not a string
:cell-attrs="() => ({ style: { width: '100%' }, class: 'foobar' })"

@portikM portikM self-assigned this Oct 29, 2024
@portikM portikM requested a review from a team as a code owner October 29, 2024 16:14
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 2e12761
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67210ad09627850008309f9b
😎 Deploy Preview https://deploy-preview-2490--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 2e12761
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67210ad0dbdacf0008125ada
😎 Deploy Preview https://deploy-preview-2490--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM enabled auto-merge (squash) October 29, 2024 16:16
@portikM portikM disabled auto-merge October 29, 2024 16:17
adamdehaven
adamdehaven previously approved these changes Oct 29, 2024
View reviewed changes
@portikM portikM enabled auto-merge (squash) October 29, 2024 16:18
@portikM portikM changed the title fix(ktableview, ktabledata): cell-attrs prop type fix(ktableview, ktabledata): cell-attrs and row-attrs prop type Oct 29, 2024
@portikM portikM merged commit 7e28e39 into main Oct 29, 2024
11 checks passed
@portikM portikM deleted the fix/tables-cell-attrs-prop-type branch October 29, 2024 16:25
kongponents-bot pushed a commit that referenced this pull request Oct 29, 2024
@semantic-release-bot
chore(release): 9.14.2 [skip ci]
7038169 
## [9.14.2](v9.14.1...v9.14.2) (2024-10-29)

### Bug Fixes

* **ktableview, ktabledata:** cell-attrs prop type ([#2490](#2490)) ([7e28e39](7e28e39))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.14.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @adamdehaven