fix(kselect): clear filter on blur [KHCP-13444] #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portikM
requested review from
adamdehaven,
jillztom,
Justineo and
a team
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Justineo
previously approved these changes
Oct 29, 2024
| // add an item with `enter` | ||
| const handleAddItem = (): void => { | ||
| if (!props.enableItemCreation || !filterString.value || !uniqueFilterStr.value) { | ||
| if (!props.enableItemCreation || !filterString.value || !uniqueFilterStr.value || !props.itemCreationValidator(filterString.value)) { |
There was a problem hiding this comment.
non blocking: It seems that we are missing itemCreationValidator in <KSelect>, shall we align this?
There was a problem hiding this comment.
Already have a PR for this: #2485
kongponents-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
## [9.14.1](v9.14.0...v9.14.1) (2024-10-29) ### Bug Fixes * **kselect:** clear filter on blur [KHCP-13444] ([#2486](#2486)) ([83da311](83da311))
|
🎉 This PR is included in version 9.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13444