feat(kbutton): add appearance="none" to button #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justineo
requested review from
adamdehaven,
jillztom and
a team
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Justineo
commented
Oct 18, 2024
adamdehaven
reviewed
Oct 18, 2024
|
When we utilize an icon button, or button with icon, and with
As examples here, ideally, the button would still align with the other buttons in the row, just without the background color, etc. We'd still want the gap between the icon + text, and the padding around the icon (probably?) |
adamdehaven
approved these changes
Oct 23, 2024
kongponents-bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
# [9.13.0](v9.12.1...v9.13.0) (2024-10-23) ### Features * **kbutton:** add appearance="none" to button ([#2469](#2469)) ([30fb03a](30fb03a))
|
🎉 This PR is included in version 9.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
nonevalue to the<KButton>appearanceprop, enabling buttons to render with minimal styling similar to a<div>. This allows for fully custom styles while retaining<KButton>features like link rendering to links, cursor styles, and disabled states.Changes
New Appearance:
none<KButton>with minimal styles (border-box,cursor) for custom styling.Style Refactoring
.k-buttonno longer applies primary styles unless theprimaryclass is present to make overriding easier.primary outlineclasses to maintain backward compatibility whenappearance="outline"(or any other invalid values).Disabled Link Behavior
pointer-events: noneto ensurecursor: not-alloweddisplays correctly for consistency.