Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ktable): bulk actions checkboxes should be valign center #2446

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

Justineo
Copy link
Contributor

@Justineo Justineo commented Oct 9, 2024

Summary

Before:

image

After:

image

@Justineo Justineo requested a review from a team as a code owner October 9, 2024 08:40
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit bcaf401
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6706416327ba2e0008b5ef4f
😎 Deploy Preview https://deploy-preview-2446--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -192,7 +192,7 @@ export default {
position: relative;

&.has-label {
margin-top: 3px; // align with label
margin-top: 2px; // align with label
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(20 - 16) / 2

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit bcaf401
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6706416337297f00085dc445
😎 Deploy Preview https://deploy-preview-2446--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Justineo Justineo enabled auto-merge (squash) October 10, 2024 01:25
@Justineo Justineo merged commit cfca76a into main Oct 12, 2024
11 checks passed
@Justineo Justineo deleted the fix/table-checkbox-align branch October 12, 2024 00:42
kongponents-bot pushed a commit that referenced this pull request Oct 12, 2024
## [9.11.2](v9.11.1...v9.11.2) (2024-10-12)

### Bug Fixes

* **ktable:** bulk actions checkboxes should be valign center ([#2446](#2446)) ([cfca76a](cfca76a))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants