Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kmultiselect): arrow keys navigation [KHCP-13121] #2433

Merged
merged 6 commits into from
Oct 4, 2024
Merged

fix(kmultiselect): arrow keys navigation [KHCP-13121] #2433

merged 6 commits into from
Oct 4, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Oct 2, 2024 •
edited
Loading

Summary

Jira: https://konghq.atlassian.net/browse/KHCP-13121

Changes:

  • allow navigating through KMultiselect items using keyboard up and down keys
  • fix a bug in KSelect where navigating using up and down keys was working incorrectly when items were passed in indirect order

@portikM portikM self-assigned this Oct 2, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit f127d9d
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/670020d7f1e57800081211fd
😎 Deploy Preview https://deploy-preview-2433--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit f127d9d
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/670020d70951ef0008b5fb49
😎 Deploy Preview https://deploy-preview-2433--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM mentioned this pull request Oct 4, 2024
Closed
aanchalm01
aanchalm01 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@aanchalm01 aanchalm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@portikM portikM merged commit b26825a into main Oct 4, 2024
11 checks passed
@portikM portikM deleted the fix/khcp-13121-kmultiselect-keyboard-navigation branch October 4, 2024 19:07
kongponents-bot pushed a commit that referenced this pull request Oct 4, 2024
@semantic-release-bot
chore(release): 9.10.3 [skip ci]
e2a518f 
## [9.10.3](v9.10.2...v9.10.3) (2024-10-04)

### Bug Fixes

* **kmultiselect:** arrow keys navigation [KHCP-13121] ([#2433](#2433)) ([b26825a](b26825a))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanchalm01 aanchalm01 aanchalm01 approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot is a code owner

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@kaiarrowood kaiarrowood Awaiting requested review from kaiarrowood kaiarrowood is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @aanchalm01