feat(kmultiselect): add search-placeholder prop [KHCP-13352] #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Justineo
reviewed
Sep 29, 2024
| searchPlaceholder: { | ||
| type: String, | ||
| default: '', | ||
| }, |
There was a problem hiding this comment.
Shall we warn users when collapsedContext is true but placeholder is not empty?
There was a problem hiding this comment.
I don't think that's necessary: the default displayed text for both modes is 0 items selected - I don't think we need to specifically point that out.
adamdehaven
approved these changes
Sep 30, 2024
kongponents-bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
# [9.9.0](v9.8.4...v9.9.0) (2024-09-30) ### Features * **kmultiselect:** add search-placeholder prop [KHCP-13352] ([#2419](#2419)) ([4062052](4062052))
|
🎉 This PR is included in version 9.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jira: https://konghq.atlassian.net/browse/KHCP-13352
Changes (KMultiselect):
searchPlaceholderprop that acts as search input placeholdersearchPlaceholderprop displays in the trigger element when no items are selectedsearchPlaceholdersets a placeholder in search input inside multiselect dropdownplaceholderprop (if has value) is used as trigger element text when no items are selectedplaceholderandsearchPlaceholderprops documentation