Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ktreelist): fix multiple emits #2334

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

portikM
Copy link
Member

@portikM portikM commented Aug 12, 2024

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-12985

  1. Fixes multiple selected event emits on item select (screenshots)
  2. Fixes weird dragging behaviour where after starting dragging a second click is needed to "release" dragged element

Before:

@selected="onSelected"

const onSelected = (item: TreeListItem) => {
  console.log('onSelected', item)
}
Screenshot 2024-08-12 at 3 08 27 PM

After:
Only 1 event is emitted

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@portikM portikM self-assigned this Aug 12, 2024
@portikM portikM requested a review from a team as a code owner August 12, 2024 19:14
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 0201030
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/66bbd21ea9f191000817c272
😎 Deploy Preview https://deploy-preview-2334--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 0201030
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/66bbd21e8639a90008c128e1
😎 Deploy Preview https://deploy-preview-2334--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as draft August 12, 2024 19:34
@portikM portikM marked this pull request as ready for review August 13, 2024 21:41
@portikM portikM enabled auto-merge (squash) August 13, 2024 21:43
@portikM portikM merged commit a167050 into main Aug 13, 2024
9 checks passed
@portikM portikM deleted the fix/ktreelist-multiple-emits branch August 13, 2024 21:45
kongponents-bot pushed a commit that referenced this pull request Aug 13, 2024
## [9.2.2](v9.2.1...v9.2.2) (2024-08-13)

### Bug Fixes

* **ktreelist:** fix multiple emits ([#2334](#2334)) ([a167050](a167050))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants