Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kslideout): content being taller than viewport when using props.offsetTop #1822

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix(kslideout): content being taller than viewport when using props.offsetTop #1822

merged 1 commit into from
Nov 6, 2023

Conversation

kleinfreund
Copy link
Contributor

Summary

Fixes the content area always as tall as the viewport when using props.offsetTop making it too tall.

Signed-off-by: Philipp Rudloff [email protected]

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

fix(kslideout): content being taller than viewport when using props.o…
bca403c 
…ffsetTop

Fixes the content area always as tall as the viewport when using `props.offsetTop` making it too tall.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund kleinfreund self-assigned this Nov 6, 2023
@kleinfreund kleinfreund requested a review from a team as a code owner November 6, 2023 12:50
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2023 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit bca403c
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6548e12980734c00089f35a8
😎 Deploy Preview https://deploy-preview-1822--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2023

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit bca403c
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6548e12a834bb50008826883
😎 Deploy Preview https://deploy-preview-1822--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adamdehaven
adamdehaven approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kleinfreund kleinfreund merged commit 197fdab into alpha Nov 6, 2023
6 checks passed
@kleinfreund kleinfreund deleted the fix/slideout-content-being-taller-than-viewport-height-when-using-offset-top branch November 6, 2023 14:19
@kleinfreund kleinfreund removed their assignment Nov 6, 2023
kongponents-bot pushed a commit that referenced this pull request Nov 6, 2023
@semantic-release-bot
chore(release): 9.0.0-alpha.43 [skip ci]
a708333 
# [9.0.0-alpha.43](v9.0.0-alpha.42...v9.0.0-alpha.43) (2023-11-06)

### Bug Fixes

* **kpagination:** select widget too thin for wide content ([#1821](#1821)) ([9ff9f65](9ff9f65))
* **kslideout:** content being taller than viewport when using props.offsetTop ([#1822](#1822)) ([197fdab](197fdab))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.43 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kleinfreund @kongponents-bot @adamdehaven