fix(kpagination): select widget too thin for wide content #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the KSelect’s `props.width` value from `170` to `190` to account for the widest default content (i.e. "100 items per page"). This otherwise triggers the pagination to overflow (e.g. causes a horizontal scrollbar in KTable). Signed-off-by: Philipp Rudloff <[email protected]>
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kleinfreund
deleted the
fix/pagination-select-widget-being-too-thin-for-widest-content
branch
|
🎉 This PR is included in version 9.0.0-alpha.43 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the KSelect’s
props.widthvalue from170to190to account for the widest default content (i.e. "100 items per page"). This otherwise triggers the pagination to overflow (e.g. causes a horizontal scrollbar in KTable).Before:
After:
PR Checklist