Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ktooltip): render a plain slot if no label or content #1802

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Oct 30, 2023

Summary

This PR removes KPop entirely if no label or content is provided. Instead, it'll only render the default slot.

Before:
image

After:
image

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@Leopoldthecoder Leopoldthecoder requested a review from a team as a code owner October 30, 2023 07:19
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit ecd42ba
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/653faca03a505b00088185ee
😎 Deploy Preview https://deploy-preview-1802--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamdehaven adamdehaven merged commit 56b29e6 into main Oct 30, 2023
5 checks passed
@adamdehaven adamdehaven deleted the feat/tooltip-no-label branch October 30, 2023 13:37
kongponents-bot pushed a commit that referenced this pull request Oct 30, 2023
# [8.125.0](v8.124.1...v8.125.0) (2023-10-30)

### Features

* **ktooltip:** render a plain slot if no label or content ([#1802](#1802)) ([56b29e6](56b29e6))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.125.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kongponents-bot pushed a commit that referenced this pull request Oct 30, 2023
# [9.0.0-alpha.33](v9.0.0-alpha.32...v9.0.0-alpha.33) (2023-10-30)

### Features

* **ktooltip:** render a plain slot if no label or content ([#1802](#1802)) ([56b29e6](56b29e6))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants