Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kcodeblock): not searching long content with short queries #1797

Merged

Conversation

kleinfreund
Copy link
Contributor

Summary

Removes the limitation to only trigger a search when (1) a piece of code is shorter than 1000 characters or (2) the query is greater than 2 characters.

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 4b141bf
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/653b8b1d02afce0008f942cf
😎 Deploy Preview https://deploy-preview-1797--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Removes the limitation to only trigger a search when (1) a piece of code is shorter than 1000 characters or (2) the query is greater than 2 characters.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund kleinfreund force-pushed the fix/code-block-not-searching-long-content-for-short-queries branch from 0971b43 to 4b141bf Compare October 27, 2023 10:04
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 0971b43
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/653b8ac70ba0af00081abb51
😎 Deploy Preview https://deploy-preview-1797--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 4b141bf
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/653b8b1d29acfa0008e2e64a
😎 Deploy Preview https://deploy-preview-1797--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kleinfreund kleinfreund marked this pull request as ready for review October 27, 2023 10:22
@kleinfreund kleinfreund requested a review from a team as a code owner October 27, 2023 10:22
@kleinfreund
Copy link
Contributor Author

Comment: The Percy failure is in the date picker component so unrelated to this change.

Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kleinfreund kleinfreund merged commit 7e5e891 into alpha Oct 27, 2023
6 checks passed
@kleinfreund kleinfreund deleted the fix/code-block-not-searching-long-content-for-short-queries branch October 27, 2023 14:35
kongponents-bot pushed a commit that referenced this pull request Oct 27, 2023
# [9.0.0-alpha.30](v9.0.0-alpha.29...v9.0.0-alpha.30) (2023-10-27)

### Bug Fixes

* **kcodeblock:** not searching long content with short queries ([#1797](#1797)) ([7e5e891](7e5e891))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants