Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): deprecate and update boolean props [KHCP-9548] #1793

Merged
merged 10 commits into from
Oct 26, 2023
Merged

fix(*): deprecate and update boolean props [KHCP-9548] #1793

merged 10 commits into from
Oct 26, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Oct 26, 2023 •
edited
Loading

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-9548

Changes:

  • KInput:
    • deprecate hasError prop in favor of error
    • update underlying class structure to match the change
  • KDropdown:
    • change isSelectionMenu prop to selectionMenu
    • KDropdownItem:
      • deprecate isDangerous prop in favor of danger

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@portikM portikM self-assigned this Oct 26, 2023
@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 8447b9c
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/653acb1179300a0008da27fb
😎 Deploy Preview https://deploy-preview-1793--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 8447b9c
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/653acb11bdf51a00080d12f2
😎 Deploy Preview https://deploy-preview-1793--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM changed the title fix(kinput): deprecate hasError prop in favor of error [KHCP-9548] fix(*): deprecate and update boolean props [KHCP-9548] Oct 26, 2023
@portikM portikM marked this pull request as ready for review October 26, 2023 20:07
adamdehaven
adamdehaven reviewed Oct 26, 2023
View reviewed changes
src/components/KDropdown/KDropdownItem.vue Outdated Show resolved Hide resolved
src/components/KInput/KInput.vue Outdated Show resolved Hide resolved
@portikM portikM requested a review from adamdehaven October 26, 2023 20:35
adamdehaven
adamdehaven approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM merged commit 9b97cf8 into alpha Oct 26, 2023
6 checks passed
@portikM portikM deleted the fix/khcp-9548-boolean-props branch October 26, 2023 21:19
kongponents-bot pushed a commit that referenced this pull request Oct 26, 2023
@semantic-release-bot
chore(release): 9.0.0-alpha.29 [skip ci]
4d375b5 
# [9.0.0-alpha.29](v9.0.0-alpha.28...v9.0.0-alpha.29) (2023-10-26)

### Bug Fixes

* deprecate and update boolean props [KHCP-9548] ([#1793](#1793)) ([9b97cf8](9b97cf8))
* **deps:** update dependency @kong/icons to ^1.7.8 ([#1795](#1795)) ([221adcb](221adcb))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@kaiarrowood kaiarrowood Awaiting requested review from kaiarrowood kaiarrowood is a code owner

Assignees

@portikM portikM

Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @adamdehaven