feat(kcheckbox): reskin component [KHCP-8973] #1792
Conversation
portikM
requested review from
kongponents-bot,
adamdehaven,
jillztom,
kaiarrowood and
a team
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
portikM
force-pushed
the
feat/khcp-8973-kcheckbox-component-reskin
branch
6 times, most recently
from
74d9089 to
131047d
Compare
portikM
force-pushed
the
feat/khcp-8973-kcheckbox-component-reskin
branch
from
131047d to
2cf0a97
Compare
| @mixin kCheckboxIcon { | ||
| inset: 0; | ||
| left: calc(50% - 2.4px); // 2px is not enough, 3px is too much... | ||
| pointer-events: none; | ||
| position: absolute; | ||
| top: calc(50% + 1.75px); // 1px is not enough, 2px is too much... | ||
| transform: translate(-50%, -50%); | ||
| z-index: 1; | ||
| } |
There was a problem hiding this comment.
suggestion: can this go in the mixins file?
There was a problem hiding this comment.
I don't think this mixin will be reused - it's pretty specific to this component so I would leave it here.
| .checkbox-input { | ||
| @include radioCheckboxDefaults; | ||
|
|
||
| border-radius: var(--kui-border-radius-20, $kui-border-radius-20); |
There was a problem hiding this comment.
I'm assuming we're overriding the radius of the mixin above? If yes, can you please add a comment on the line above?
There was a problem hiding this comment.
No - the mixin doesn't have the border-radius property (because it's used in both KRadio and KCheckbox - there's no default value we want for it). So here we're literally setting border-radius property (same in KRadio). I will add a comment mentioning that.
Co-authored-by: Adam DeHaven <[email protected]>
# [9.0.0-alpha.31](v9.0.0-alpha.30...v9.0.0-alpha.31) (2023-10-27) ### Features * **kcheckbox:** reskin component [KHCP-8973] ([#1792](#1792)) ([af7c0d5](af7c0d5))
|
🎉 This PR is included in version 9.0.0-alpha.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Jira
Figma
KCheckbox component reskinning.
Links:
PR Checklist