Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ktooltip, klabel): remove tooltip slot wrapper #1785

Merged
merged 3 commits into from
Oct 20, 2023
Merged

fix(ktooltip, klabel): remove tooltip slot wrapper #1785

merged 3 commits into from
Oct 20, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Oct 20, 2023

Summary

Remove slot wrapper div and add tabindex to label tooltip trigger icon

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@portikM portikM self-assigned this Oct 20, 2023
@portikM portikM requested a review from a team as a code owner October 20, 2023 18:28
@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 553f870
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6532ca3774bc170008870a1b
😎 Deploy Preview https://deploy-preview-1785--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 553f870
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6532ca37cd5a06000860b58f
😎 Deploy Preview https://deploy-preview-1785--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM enabled auto-merge (squash) October 20, 2023 18:33
adamdehaven
adamdehaven previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM disabled auto-merge October 20, 2023 18:41
@portikM portikM enabled auto-merge (squash) October 20, 2023 18:43
@portikM portikM merged commit cd55f54 into alpha Oct 20, 2023
6 checks passed
@portikM portikM deleted the fix/ktooltip-slot-wrapper branch October 20, 2023 18:50
kongponents-bot pushed a commit that referenced this pull request Oct 20, 2023
@semantic-release-bot
chore(release): 9.0.0-alpha.25 [skip ci]
a7d5abe 
# [9.0.0-alpha.25](v9.0.0-alpha.24...v9.0.0-alpha.25) (2023-10-20)

### Bug Fixes

* **ktooltip, klabel:** remove tooltip slot wrapper ([#1785](#1785)) ([cd55f54](cd55f54))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

Assignees

@portikM portikM

Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @adamdehaven