Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ktooltip): hide tooltip if no label or content #1783

Merged
merged 4 commits into from
Oct 20, 2023
Merged

feat(ktooltip): hide tooltip if no label or content #1783

merged 4 commits into from
Oct 20, 2023

Conversation

adamdehaven
Copy link
Member

Summary

Hide the tooltip popover if no label prop or content slot template is provided.

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@adamdehaven adamdehaven self-assigned this Oct 20, 2023
@adamdehaven adamdehaven requested a review from a team as a code owner October 20, 2023 16:19
@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit ddc778e
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6532b33f5a2f0b00087440f3
😎 Deploy Preview https://deploy-preview-1783--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kaiarrowood
kaiarrowood previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

kaiarrowood
kaiarrowood approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adamdehaven adamdehaven merged commit 469b3b6 into main Oct 20, 2023
5 checks passed
@adamdehaven adamdehaven deleted the feat/k-tooltip-no-content branch October 20, 2023 17:22
@adamdehaven adamdehaven mentioned this pull request Oct 20, 2023
Merged
6 tasks
kongponents-bot pushed a commit that referenced this pull request Oct 20, 2023
@semantic-release-bot
chore(release): 9.0.0-alpha.24 [skip ci]
51967d3 
# [9.0.0-alpha.24](v9.0.0-alpha.23...v9.0.0-alpha.24) (2023-10-20)

### Features

* **ktooltip:** hide tooltip if no label or content ([#1783](#1783)) ([469b3b6](469b3b6))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

kongponents-bot pushed a commit that referenced this pull request Oct 20, 2023
@semantic-release-bot
chore(release): 8.124.0 [skip ci]
7f15e7e 
# [8.124.0](v8.123.9...v8.124.0) (2023-10-20)

### Features

* **ktooltip:** hide tooltip if no label or content ([#1783](#1783)) ([469b3b6](469b3b6))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.124.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiarrowood kaiarrowood kaiarrowood approved these changes

Assignees

@adamdehaven adamdehaven

Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdehaven @kongponents-bot @kaiarrowood