Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kdropdownmenu): component reskinning (alternative) [KHCP-8879] #1780

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(kdropdown): spacing tweaks [KHCP-8879]
portikM committed Oct 19, 2023
commit 0c3d95ea5f21fe685bab4a557c5d74a80d8b8b16
2 changes: 1 addition & 1 deletion src/components/KDropdown/KDropdown.vue
Original file line number Diff line number Diff line change
@@ -240,7 +240,7 @@ onMounted(() => {

ul {
margin: 0;
padding: 0;
padding: var(--kui-space-20, $kui-space-20) 0;
}
}
}
24 changes: 9 additions & 15 deletions src/components/KDropdown/KDropdownItem.vue
Original file line number Diff line number Diff line change
@@ -175,24 +175,18 @@ const availableComponents = computed((): DropdownItemRenderedRecord => ({
justify-content: space-between;
list-style: none;

&:first-of-type {
.k-dropdown-item-trigger {
border-top-left-radius: var(--kui-border-radius-30, $kui-border-radius-30);
border-top-right-radius: var(--kui-border-radius-30, $kui-border-radius-30);
}
}
&.has-divider {
display: flex;
flex-direction: column;

&:last-of-type {
.k-dropdown-item-trigger {
border-bottom-left-radius: var(--kui-border-radius-30, $kui-border-radius-30);
border-bottom-right-radius: var(--kui-border-radius-30, $kui-border-radius-30);
&::before {
border-top: var(--kui-border-width-10, $kui-border-width-10) solid var(--kui-color-border, $kui-color-border);
content: '';
margin: var(--kui-space-20, $kui-space-20) 0;
width: 100%;
}
}

&.has-divider {
border-top: var(--kui-border-width-10, $kui-border-width-10) solid var(--kui-color-border, $kui-color-border);
}

&.danger {
.k-dropdown-item-trigger {
color: var(--kui-color-text-danger, $kui-color-text-danger);
@@ -224,7 +218,7 @@ const availableComponents = computed((): DropdownItemRenderedRecord => ({
font-size: var(--kui-font-size-30, $kui-font-size-30);
font-weight: var(--kui-font-weight-medium, $kui-font-weight-medium);
line-height: var(--kui-line-height-40, $kui-line-height-40);
padding: var(--kui-space-50, $kui-space-50) var(--kui-space-60, $kui-space-60);
padding: var(--kui-space-40, $kui-space-40) var(--kui-space-60, $kui-space-60);
text-align: left;
text-decoration: none;
transition: background-color $kongponentsTransitionDurTimingFunc, color $kongponentsTransitionDurTimingFunc;