Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ktabs): removes unnecessary pseudo element #1774

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

kleinfreund
Copy link
Contributor

Summary

Removes the .k-tabs ul .tab-item:after pseudo element styles as they don’t seem to have a clear purpose and interfere with rendering of KTabs within overflowing containers.

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@kleinfreund kleinfreund self-assigned this Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 8686626
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/652ea01d05a5170008530104
😎 Deploy Preview https://deploy-preview-1774--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kleinfreund kleinfreund marked this pull request as ready for review October 17, 2023 14:09
@kleinfreund kleinfreund requested a review from a team as a code owner October 17, 2023 14:09
@kleinfreund
Copy link
Contributor Author

@adamdehaven Just FYI, netlify/kongponents/depoy-preview failed on this PR as well (https://app.netlify.com/sites/kongponents/deploys/652e946f10a61a00087774bd). I’ll wait with pushing another change in case of PR feedback.

@adamdehaven
Copy link
Member

image
Looks like a Netlify issue

Removes the `.k-tabs ul .tab-item:after` pseudo element styles as they don’t seem to have a clear purpose and interfere with rendering of KTabs within overflowing containers.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund kleinfreund force-pushed the chore/remove-unnecessary-pseudo-element branch from 25ef8f3 to 8686626 Compare October 17, 2023 14:54
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 8686626
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/652ea01d148cb00008e2583b
😎 Deploy Preview https://deploy-preview-1774--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@portikM portikM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kleinfreund kleinfreund merged commit d28deb8 into alpha Oct 17, 2023
6 checks passed
@kleinfreund kleinfreund deleted the chore/remove-unnecessary-pseudo-element branch October 17, 2023 17:08
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants