Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(clustering/rpc): reshape do_sync #14199

Merged
merged 1 commit into from
Jan 22, 2025
Merged

refactor(clustering/rpc): reshape do_sync #14199

merged 1 commit into from
Jan 22, 2025

Conversation

StarlightIbuki
Copy link
Contributor

KAG-6177

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jan 20, 2025
@StarlightIbuki StarlightIbuki force-pushed the refactor/do_sync branch 2 times, most recently from db3f624 to 5c6e65b Compare January 20, 2025 08:25
@StarlightIbuki StarlightIbuki force-pushed the refactor/do_sync branch 2 times, most recently from 4d7dbec to 94a3614 Compare January 20, 2025 08:43
ADD-SP
ADD-SP reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    kong/clustering/services/sync/rpc.lua:306:11: unused variable operation_name
    kong/clustering/services/sync/rpc.lua:312:25: accessing undefined variable delta_type

Could you fix the linting?

@StarlightIbuki
Copy link
Contributor Author 

    kong/clustering/services/sync/rpc.lua:306:11: unused variable operation_name
    kong/clustering/services/sync/rpc.lua:312:25: accessing undefined variable delta_type

Could you fix the linting?

done

@StarlightIbuki StarlightIbuki force-pushed the refactor/do_sync branch 3 times, most recently from 55a0eca to 3b56b2a Compare January 20, 2025 10:22
chronolaw
chronolaw reviewed Jan 21, 2025
View reviewed changes
kong/clustering/services/sync/rpc.lua Outdated Show resolved Hide resolved
kong/clustering/services/sync/rpc.lua Show resolved Hide resolved
kong/clustering/services/sync/rpc.lua Outdated Show resolved Hide resolved
kong/clustering/services/sync/rpc.lua Show resolved Hide resolved
@StarlightIbuki StarlightIbuki force-pushed the refactor/do_sync branch 2 times, most recently from 64fbb24 to bb1970f Compare January 21, 2025 08:57
@ADD-SP ADD-SP added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 22, 2025
@ADD-SP ADD-SP merged commit 1d0f212 into master Jan 22, 2025
30 checks passed
@ADD-SP ADD-SP deleted the refactor/do_sync branch January 22, 2025 04:35
@ADD-SP ADD-SP removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP left review comments

@chronolaw chronolaw chronolaw approved these changes

@chobits chobits chobits approved these changes

Assignees

@StarlightIbuki StarlightIbuki

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StarlightIbuki @chobits @chronolaw @ADD-SP