separate plugin server runtime data from kong configuration #14111
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d not be cjson encoded
ProBrian
commented
Jan 9, 2025
| @@ -150,16 +151,19 @@ local function pluginserver_timer(premature, server_def) | |||
| end | |||
|
|
|||
| kong.log.notice("[pluginserver] starting pluginserver process for ", server_def.name or "") | |||
| server_def.proc = assert(ngx_pipe.spawn("exec " .. server_def.start_command, { | |||
There was a problem hiding this comment.
the server_ref passed in here is the reference of kong.configuration.pluginservers, so the proc(which is just a runtime sub process handle) here will be included in configuration, which is not reasonable, and also causes encoding of configuration failed on admin API GET method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem: There are some runtime data like
procstored inkong.configuration.pluginservers, which is cdata type and could not be encoded by cjson. Thus when fetching the admin api "/", the response body encoding of configuration will fail and throws 500 error.Solution: Separate runtime data from configuration, store runtime info like
procinside the plugin servers module, not global configuration.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix https://konghq.atlassian.net/browse/KAG-6088