Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering/rpc): check deltas if it is nil #14064

Merged
merged 3 commits into from
Jan 2, 2025
Merged

fix(clustering/rpc): check deltas if it is nil #14064

merged 3 commits into from
Jan 2, 2025

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 30, 2024 •
edited
Loading

Summary

KAG-6098

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 30, 2024
@ADD-SP ADD-SP changed the title style(clustering/rpc): check deltas if it is nil fix(clustering/rpc): check deltas if it is nil Dec 30, 2024
@chronolaw chronolaw marked this pull request as draft December 30, 2024 08:40
@chronolaw
Copy link
Contributor Author

We have some discussion about this topic, so turn it to draft.

@chronolaw chronolaw marked this pull request as ready for review January 2, 2025 07:37
@ms2008 ms2008 merged commit e0d6df7 into master Jan 2, 2025
26 checks passed
@ms2008 ms2008 deleted the style/check_default_deltas branch January 2, 2025 08:13
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@lhanjian lhanjian lhanjian approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @team-gateway-bot @lhanjian @ADD-SP @ms2008