Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(pdk): rename some variables #14063

Merged
merged 1 commit into from
Dec 30, 2024
Merged

style(pdk): rename some variables #14063

merged 1 commit into from
Dec 30, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 30, 2024

Summary

KAG-6036
It is a follow up of #14025

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/pdk cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 30, 2024
@ADD-SP ADD-SP merged commit 0b74d0f into master Dec 30, 2024
40 checks passed
@ADD-SP ADD-SP deleted the style/clean_for_vault branch December 30, 2024 06:24
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-14063-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-14063-to-master-to-upstream
git checkout -b cherry-pick-14063-to-master-to-upstream
ancref=$(git merge-base 0ebc358063569cb08bba8e8bdf1586c2146ed9a0 11e3ec40d292a4a385f988d52f47de4170ba4104)
git cherry-pick -x $ancref..11e3ec40d292a4a385f988d52f47de4170ba4104

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Dec 30, 2024
@chronolaw
Copy link
Contributor Author

cherry-pick is blocked by https://github.com/Kong/kong-ee/pull/11082

@chronolaw chronolaw added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 30, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants