tests(clustering): dp status ready when use RPC Sync

[lhanjian]

Summary

Checklist

• The Pull Request has tests
• A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
• There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5994

[chronolaw]

We should remove -- XXX FIXME and skip_rpc_sync also.

[chronolaw]

I think that you misunderstand my words, we still need this case for rpc_sync = off but not use skip_rpc_sync, it should be a normal it()

[lhanjian]

fixed

[chronolaw]

It should also support {"off", "off"}

[chobits]

note that "off" "off" has been supported by original test case, see Line 107,
I think we should write a completely new on on case to test incremental sync mode, like

if off off
-- using original cases
end

if on on then
-- write new cases in this pr
describe / it ()
....
end
end

So the new case does not need to support on

[chobits]

because the original case (off off) will restart CP, if we implement new case in this scenario, current CP/DP incremental sync is hard to make the case stable, it is easy to get flakiness.

Why?

because restarting CP will cause DP connecting CP and introduce some delay, and currently in incremental sync feature, we could not have a good way to ensure the established connection between CP and DP. I think if we want to test CP/DP restart , we could file a new kag to track.

[chronolaw]

It should also support {"off", "off"}

[chobits]

wait for CI to become green, and also note fix my coding style recommendation

[team-gateway-bot]

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-14035-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-14035-to-master-to-upstream
git checkout -b cherry-pick-14035-to-master-to-upstream
ancref=$(git merge-base 14b1bf96dc37326bcca06eab15ae0bdec74cf013 b03b074daf8bc6fb6b905315ce2cddaabe4c77a2)
git cherry-pick -x $ancref..b03b074daf8bc6fb6b905315ce2cddaabe4c77a2