Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lmdb): remove the key with global workspace id * #14028

Merged
merged 15 commits into from
Dec 23, 2024

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Dec 17, 2024

Summary

  1. redesign the key format for LMDB
  2. remove the key with * workspace
  3. search all the workspaces if upper user calls select() API without providing the specific workspace id

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5704

@github-actions github-actions bot added core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 17, 2024
@chobits
Copy link
Contributor Author

chobits commented Dec 17, 2024

kong/db/strategies/off/init.lua Show resolved Hide resolved
kong/db/strategies/off/init.lua Outdated Show resolved Hide resolved
@chobits chobits force-pushed the fix/lmdb_reduce_global_query branch from 193f5b4 to 2e9a2ff Compare December 18, 2024 15:10
@chobits
Copy link
Contributor Author

chobits commented Dec 19, 2024

cherry-pick will fail, so i file one cherry-pick pr: https://github.com/Kong/kong-ee/pull/10965 (cases passed

@ADD-SP ADD-SP merged commit 1458161 into master Dec 23, 2024
26 checks passed
@ADD-SP ADD-SP deleted the fix/lmdb_reduce_global_query branch December 23, 2024 06:20
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-14028-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-14028-to-master-to-upstream
git checkout -b cherry-pick-14028-to-master-to-upstream
ancref=$(git merge-base f7f7a2349ecc96b505a6f3dac7f4e8fae84d004f 2d3f89245e7d2eb5f21b985d9389f934f12aef30)
git cherry-pick -x $ancref..2d3f89245e7d2eb5f21b985d9389f934f12aef30

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Dec 23, 2024
@chobits
Copy link
Contributor Author

chobits commented Dec 23, 2024

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-14028-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-14028-to-master-to-upstream
git checkout -b cherry-pick-14028-to-master-to-upstream
ancref=$(git merge-base f7f7a2349ecc96b505a6f3dac7f4e8fae84d004f 2d3f89245e7d2eb5f21b985d9389f934f12aef30)
git cherry-pick -x $ancref..2d3f89245e7d2eb5f21b985d9389f934f12aef30

manual cherry-pick https://github.com/Kong/kong-ee/pull/10965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants