-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(db): ensure that flattened_errors is encoded as a JSON array #14019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Dec 13, 2024
gszr
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Can we add a regression test for it?
flrgh
force-pushed
the
fix/flattened-errors-json-array
branch
from
December 17, 2024 21:37
381e87a
to
d1e4d43
Compare
flrgh
force-pushed
the
fix/flattened-errors-json-array
branch
from
December 17, 2024 21:38
d1e4d43
to
0f55428
Compare
I wonder how many more times we'll have to fix this sorta thing...
flrgh
force-pushed
the
fix/flattened-errors-json-array
branch
from
December 17, 2024 21:41
0f55428
to
cc023e8
Compare
|
kevwilliams
approved these changes
Dec 18, 2024
brentos
approved these changes
Dec 18, 2024
gszr
approved these changes
Dec 18, 2024
Successfully created cherry-pick PR for |
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
) * fix(db): ensure that flattened_errors is encoded as a JSON array (#14019) (cherry picked from commit f7f7a23) * chore(*): add copyright header --------- Co-authored-by: Michael Martin <[email protected]> Co-authored-by: Michael Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You know the deal: you create a list-like table but don't put anything in it, and all the sudden cjson thinks it's an object!
I wonder how many more times I'll fix this in my tenure at Kong 🤔
Well, this one is fixed. I even added a little helper function for it.
KAG-6032