chore(wasm): remove bundled datakit filter #14012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
cherry-pick kong-ee
flrgh
added
skip-changelog
and removed
cherry-pick kong-ee
|
FYI this has a changelog entry in changelog/3.9.0, but I think the changelog checker only looks in changelog/unreleased. |
brentos
approved these changes
Dec 12, 2024
flrgh
force-pushed
the
chore/wasm-unbundle-datakit-3.9.x
branch
from
39bb5a2 to
353a4ac
Compare
github-actions
bot
added
the
cherry-pick kong-ee
kikito
reviewed
Dec 12, 2024
locao
previously requested changes
Dec 12, 2024
gszr
approved these changes
Dec 12, 2024
kikito
removed
the
cherry-pick kong-ee
kikito
dismissed
locao’s stale review
We actually did have the experimental in 3.7, so removing it without a changelog entry is a bit iffy
kikito
pushed a commit
that referenced
this pull request
Dec 17, 2024
* chore(wasm): remove bundled datakit filter * change log level
kikito
added a commit
that referenced
this pull request
Dec 18, 2024
* docs(release): generate 3.9.0 changelog (#13935) * docs(release): generate 3.9.0 changelog * docs(changelog): apply suggestions for 3.9.0 changelog * chore(wasm): remove bundled datakit filter (#14012) * chore(wasm): remove bundled datakit filter * change log level * docs(changelog): update 3.9.0 changelog (#14016) --------- Co-authored-by: Michael Martin <[email protected]> Co-authored-by: Andy Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAG-6021
see also: #14013 (master branch PR)
It seemed silly to include the dependency bump changelog entry for datakit, so I removed
changelog/3.9.0/kong/bump-datakit.yml.