fix(prometheus): use configure() handler to toggle upstream_health_metrics #13983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trics This setting was added before we had the :configure() phase handler and relied instead on the :log() handler to toggle itself. I suspect that there is some buggy behavior in this approach, but it's hard to craft a test case to reliably confirm. In any case, this commit updates the plugin to use the :configure() handler to toggle the setting, as this is now the idiomatic way of performing this task.
github-actions
bot
added
plugins/prometheus
cherry-pick kong-ee
This reverts commit f97ab64.
gszr
approved these changes
Dec 10, 2024
brentos
approved these changes
Dec 11, 2024
|
Successfully created cherry-pick PR for |
ProBrian
pushed a commit
that referenced
this pull request
Dec 13, 2024
…trics (#13983) * fix(prometheus): use configure() handler to toggle upstream_health_metrics This setting was added before we had the :configure() phase handler and relied instead on the :log() handler to toggle itself. I suspect that there is some buggy behavior in this approach, but it's hard to craft a test case to reliably confirm. In any case, this commit updates the plugin to use the :configure() handler to toggle the setting, as this is now the idiomatic way of performing this task. * tests(prometheus): swap setup/teardown for their lazy variants * docs(prometheus): add changelog entry * docs(prometheus): fix changelog entry * Revert "tests(prometheus): swap setup/teardown for their lazy variants" This reverts commit f97ab64.
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This setting was added before we had the :configure() phase handler and
relied instead on the :log() handler to toggle itself. I suspect that
there is some buggy behavior in this approach, but it's hard to craft a
test case to reliably confirm. In any case, this commit updates the
plugin to use the :configure() handler to toggle the setting, as this is
now the idiomatic way of performing this task.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PRIssue reference
KAG-5984