tests(*): remove useless strategy arg from reload_kong helper function #13980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes an useless
strategy
argument from one the helpers functionreload_kong
, as well as another related functionwait_until_no_common_workers
.This argument(and the
reload_kong
function itself) was made a helpers function in PR #8670 (see the diff here, which used to be a local helper function inside a test case. The argumentstrategy
was only for sleeping a bit more time when the test was running under a Cassandra deployment and there was no other use besides this.This argument was removed in EE earlier in another PR https://github.com/Kong/kong-ee/pull/3420, in commit https://github.com/Kong/kong-ee/commit/28850266ee35f7bc4f37d0b53edade4a39aabd55, but it was not removed in CE and caused divergence between the helpers function since then.
After the investigation, I see no meaning for us to keep this argument any longer, so I created this PR to totally remove it from CE test suites and to keep a consistent function signature between CE/EE repo.
NOTE: there is no need to cherry-pick this PR to EE, or to say my expectation is cherry-picking will create an empty commit
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/FTI-5922