feat(tracing): Add instana header support in propagation #13915
+143
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/tracing
plugins/opentelemetry
schema-change-noteworthy
cherry-pick kong-ee
team-eng-enablement
added
the
author/community
samugi
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Thank you so much for this great contribution! A couple of notes:
- For consistency, this should be supported by the Zipkin plugin as well, which requires a small schema update similar to what was done for OpenTelemetry in this PR, and an integration test in
spec/03-plugins/34-zipkin/zipkin_spec.lua. - The test in
spec/01-unit/26-observability/02-propagation_strategies_spec.luashould be updated as well to include this new header format
Comment on lines
21
to
26
| if trace_id then | ||
| trace_id = trace_id:match("^(%x+)") | ||
| if not trace_id then | ||
| kong.log.warn("x-instana-t header invalid; ignoring.") | ||
| end | ||
| end |
There was a problem hiding this comment.
I would use different variables instead of reassigning the extracted trace_id to the same variable that contained the raw header's value. Here, if the match fails we're logging a warning but then the code proceeds with the raw header's value in the trace_id variable, which can be error prone.
|
In addition to my previous comment, this needs a rebase. |
SuzyWangIBMer
force-pushed
the
feat/instana_headers
branch
from
e28fb70 to
0c0f894
Compare
SuzyWangIBMer
commented
Jan 8, 2025
|
|
||
| trace_id = from_hex(trace_id_raw) or nil | ||
| span_id = from_hex(span_id_raw) or nil | ||
|
|
There was a problem hiding this comment.
I have updated trace_id, span_id, level_id variable name to trace_id_raw, span_id_raw and level_id_raw
Also since we dont use correlation_type and correlationId here, changed
level_id_raw = level_id_raw:match("^([0-1])$")
or level_id_raw:match("^([0-1]),correlationType=(.-);correlationId=(.*)")
to
level_id_raw = level_id_raw:match("^([0-1])$")
or level_id_raw:match("^([0-1]).")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #12494