Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dbless): clean logic of select_by_field #13817

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

chronolaw
Copy link
Contributor

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Oct 31, 2024
Copy link
Contributor

@chobits chobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets wait for ci to become green

@chronolaw chronolaw changed the title refactor(dbless): clean logic of selec_by_field refactor(dbless): clean logic of select_by_field Oct 31, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 31, 2024
@chronolaw chronolaw merged commit f35c3d3 into refactor/tuning_inc_sync Oct 31, 2024
33 checks passed
@chronolaw chronolaw deleted the refactor/clean_cache_key_logic branch October 31, 2024 09:12
chronolaw added a commit that referenced this pull request Oct 31, 2024
* refactor(dbless): clean logic of selec_by_field

* check schema_field
bungle pushed a commit that referenced this pull request Nov 1, 2024
* fix(db): pagesize must not be less than 2
* fix(db): set global key in lmdb
* fix(db): use request_aware_table correctly
* fix(dbless): get default workspace correctly
* fix(clustering): check latest_version and d.ws_id
* fix(clustering): fix dp do_sync()
* fix(clustering):fix declarative export sync
* fix(clustering):check latest_version == ngx_null in CP
* fix(clustering): inc sync add ws (#13790)
* fix(clustering/sync): set ws_id in do_sync()
* fix(clustering): delta version is null (#13789)
* fix(clustering/sync): delta.version may be null
* refactor(clustering): change sync data structure (#13794)
* fix(incremental sync): added comment for 2 times do_sync (#13801)
* fix(incremental sync): fix cache_key handling for select_by_cache_key (#13815)
* fix(incremental sync): fix cache_key handling for select_by_cache_key
* refactor(dbless): clean logic of select_by_field (#13817)
* refactor(dbless): clean logic of selec_by_field
* fix(incremental sync): fixed ws_id processing in _set_entity_for_txn (#13816)

---------

Co-authored-by: Xiaochen Wang <[email protected]>
Co-authored-by: Datong Sun <[email protected]>
lhanjian pushed a commit that referenced this pull request Dec 23, 2024
* fix(db): pagesize must not be less than 2
* fix(db): set global key in lmdb
* fix(db): use request_aware_table correctly
* fix(dbless): get default workspace correctly
* fix(clustering): check latest_version and d.ws_id
* fix(clustering): fix dp do_sync()
* fix(clustering):fix declarative export sync
* fix(clustering):check latest_version == ngx_null in CP
* fix(clustering): inc sync add ws (#13790)
* fix(clustering/sync): set ws_id in do_sync()
* fix(clustering): delta version is null (#13789)
* fix(clustering/sync): delta.version may be null
* refactor(clustering): change sync data structure (#13794)
* fix(incremental sync): added comment for 2 times do_sync (#13801)
* fix(incremental sync): fix cache_key handling for select_by_cache_key (#13815)
* fix(incremental sync): fix cache_key handling for select_by_cache_key
* refactor(dbless): clean logic of select_by_field (#13817)
* refactor(dbless): clean logic of selec_by_field
* fix(incremental sync): fixed ws_id processing in _set_entity_for_txn (#13816)

---------

Co-authored-by: Xiaochen Wang <[email protected]>
Co-authored-by: Datong Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants