Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(db): Always do schema reset in get_db_utils #13808

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

Oyami-Srk
Copy link
Member

Summary

We have some tests that polluted schema after run.
This is to guarantee no leftover dirty schema for the follow-up tests which may not tolerate that.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5040

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 30, 2024
@Oyami-Srk Oyami-Srk removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 30, 2024
@ADD-SP ADD-SP merged commit 13fb553 into master Oct 30, 2024
33 checks passed
@ADD-SP ADD-SP deleted the haoxuan/tests-db-schema-reset-on-get_db_utils branch October 30, 2024 08:52
StarlightIbuki pushed a commit that referenced this pull request Oct 31, 2024
…13808)

We have some tests that polluted schema after run.
This is to guarantee no leftover dirty schema for the follow-up tests which may not tolerate that.

KAG-5040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants